Skip to content

fix some export bugs#2509

Merged
TruongQuangSB merged 13 commits into
mainfrom
some-export-bugs
Jul 6, 2026
Merged

fix some export bugs#2509
TruongQuangSB merged 13 commits into
mainfrom
some-export-bugs

Conversation

@mariusheine

@mariusheine mariusheine commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed:

  • merging of cells in excel export
  • fonts in some excel exports
  • last column in pdf if not a remark column
  • unsorted and duplicate footnote shorthands in excel export
  • printing area in sxxx template

@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

136 tests  ±0   136 ✅ ±0   8m 29s ⏱️ -3s
 34 suites ±0     0 💤 ±0 
 34 files   ±0     0 ❌ ±0 

Results for commit c2c2784. ± Comparison against base commit 9b7e5d8.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test6085206640323952394PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test11328744828764996661PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test6741676693205624392PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test5654322046691794509Info__2026-04-21_10-40.planpro

org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test12010410267907523661PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test8748159755842996022PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test4258971839725997325PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test15740692582118656496Info__2026-04-21_10-40.planpro

♻️ This comment has been updated with latest results.

@mariusheine mariusheine requested a review from TruongQuangSB July 3, 2026 08:12
@TruongQuangSB TruongQuangSB merged commit ea2a5c0 into main Jul 6, 2026
44 of 50 checks passed
@TruongQuangSB TruongQuangSB deleted the some-export-bugs branch July 6, 2026 10:29
TruongQuangSB pushed a commit to SuB-PlanPro/set that referenced this pull request Jul 8, 2026
@mariusheine @TruongQuangSB
fix some export bugs (eclipse-set#2509)
fe8bc5b 
* fix merging of cells in excel export

* use font of first cell in header as fallback

* fix print area of sxxx template

* extend table model by isRemarkColumn

* properly configure isRemarkColumn for all the tables

* improve utiltity function name and usage

* fix detection of remark columns in pdf exports

* fix duplicate footnote shorthands in excel export

* retrieve workbook from sheet

* explain font fallback

* make function abstract because overriden in almost all the places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TruongQuangSB TruongQuangSB TruongQuangSB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mariusheine @TruongQuangSB